Skip to content

Rename mingw-* CI jobs to pr-* #143294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

Rename mingw-* CI jobs to pr-* #143294

merged 2 commits into from
Jul 3, 2025

Conversation

ChrisDenton
Copy link
Member

The name mingw confuses people because these CI jobs now do much more than just cross-compile to mingw.

This is basically a find/replace. I chose the name pr- because it's job is to do general PR checks,

@rustbot
Copy link
Collaborator

rustbot commented Jul 1, 2025

r? @jdno

rustbot has assigned @jdno.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 1, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 1, 2025

There are changes to the tidy tool.

cc @jieyouxu

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@workingjubilee
Copy link
Member

Run set +e
info: removing rustup home
info: removing cargo home
info: removing rustup binaries
info: rustup is uninstalled
Invalid image: pr-check-tidy
Error: Process completed with exit code 1.

@ChrisDenton
Copy link
Member Author

oh, I think having "mingw" in the name might be load-bearing...

workingjubilee
workingjubilee reviewed Jul 1, 2025
View reviewed changes
@Kobzol
Copy link
Member

Kobzol commented Jul 1, 2025

Heh, I was just thinking about this today :)

You need to rename the directory with the Dockerfile.

@ChrisDenton
Copy link
Member Author

Doh! That's totally obvious now that you mentioned it 😅

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol
Copy link
Member

Kobzol commented Jul 2, 2025

r? kobzol

@rustbot rustbot assigned Kobzol and unassigned jdno Jul 2, 2025
Kobzol
Kobzol reviewed Jul 2, 2025
View reviewed changes
@Kobzol
Copy link
Member

Kobzol commented Jul 2, 2025

Thanks!

@bors r+ rollup=never

(I want to make sure that there are no test changes

@bors
Copy link
Collaborator

bors commented Jul 2, 2025

📌 Commit 6671d9b has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2025
@bors
Copy link
Collaborator

bors commented Jul 3, 2025

⌛ Testing commit 6671d9b with merge d612081...

@bors
Copy link
Collaborator

bors commented Jul 3, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing d612081 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 3, 2025
@bors bors merged commit d612081 into rust-lang:master Jul 3, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6268d0a (parent) -> d612081 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d6120810e56387730b2e86115471354c8084ca4a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 10500.4s -> 7105.0s (-32.3%)
  2. aarch64-gnu-debug: 4076.7s -> 3645.3s (-10.6%)
  3. i686-gnu-2: 6014.6s -> 5470.6s (-9.0%)
  4. x86_64-gnu-tools: 3655.2s -> 3325.1s (-9.0%)
  5. x86_64-apple-1: 7617.4s -> 6945.3s (-8.8%)
  6. x86_64-gnu-miri: 4914.5s -> 4491.5s (-8.6%)
  7. dist-apple-various: 6144.3s -> 6669.0s (8.5%)
  8. x86_64-gnu-debug: 5755.0s -> 5267.4s (-8.5%)
  9. x86_64-rust-for-linux: 2778.8s -> 2545.4s (-8.4%)
  10. i686-gnu-nopt-1: 7815.5s -> 7217.7s (-7.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@ChrisDenton ChrisDenton deleted the rename-mingw branch July 3, 2025 10:38
This was referenced Jul 3, 2025
Merged
Open
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d612081): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.7% [-0.7%, -0.7%] 1
All ❌✅ (primary) - - 0

Cycles

Results (secondary -1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.4% [0.4%, 0.5%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.0% [-3.5%, -0.4%] 6
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 462.879s -> 461.527s (-0.29%)
Artifact size: 372.11 MiB -> 372.16 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol left review comments

@workingjubilee workingjubilee workingjubilee left review comments

Assignees

@Kobzol Kobzol

Labels
A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
8 participants
@ChrisDenton @rustbot @rust-log-analyzer @workingjubilee @Kobzol @bors @rust-timer @jdno